Change step and start position to spawn probes inside the volume instead of its borders#2
Open
michelchafouin wants to merge 1 commit into
Open
Change step and start position to spawn probes inside the volume instead of its borders#2michelchafouin wants to merge 1 commit into
michelchafouin wants to merge 1 commit into
Conversation
I would usually place the edges on the volume according to my geometry in the level. When precisely adjusting the volume face to my wall, the probe would get generated too close to the wall surface, sometimes inside my wall. This change makes sure that probes are distributed inside the volume and not on the volume borders.
Owner
|
Sorry, but the initial probe placement is made this way because you are supposed to use the cut operations. If a probe is inside walls, it should be cut with "Cut Obstructed Probes" or "Cut Inside Objects". The probes on edge also benefits placement on irregular and organic environments, because you know exactly where the initial placement is, even when partially obstructed in complex scenes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would usually place the edges of the Lightmap Probe Grid volume according to my geometry in the level.
When precisely adjusting the volume face to my wall, the probe would get generated too close to the wall surface, sometimes inside the wall.
This change makes sure that probes are distributed inside the volume and not on the volume borders.
Feel free to make it optional for legacy reasons, but from my experience with other engines, this is how I would expect it to work.